Use single instance for Core Telephony network info #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghugues
force-pushed
the
fix/single-core-telephony-instance
branch
from
e06d5d9 to
90e9552
Compare
|
Thanks for your feedback ! your suggestion has been added in 2.23.0 release (5ae3532#diff-7a9f9cf818db945492fb65614f44dadbe21b3e45887f386dd0d23b0a78f7b361) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently this SDK creates a new instance of
CTTelephonyNetworkInfoon every hit. This can cause performances issues and crashes. This issue has already been discussed publicly and fixed on several open-source SDKs. See :https://stackoverflow.com/questions/14238586/coretelephony-crash
flurry/flurry-ios-sdk#200
amplitude/Amplitude-iOS#13
Solution
Use a single shared instance of
CTTelephonyNetworkInfo.