Refactor self-signed signature handling #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are borrowed from the atc0005/check-cert project where work is underway towards implementing upcoming chain order validation support. - add new helper functions - `certs.verifySignature` - `certs.verifySignatureMD5WithRSA` - `certs.verifySignatureSHA1WithRSA` - `certs.verifySignatureECDSAWithSHA1` - remove `certs.isSelfSignedMD5WithRSA helper func - refactor `certs.isSelfSigned` to drop use of that func and use `certs.verifySignature` helper func directly - add `certs.verifySignature` func to act as entry point for all signature verification work calling out to algorithm-specific helper functions as needed - update/add `nolint:gosec` directives NOTE: I have *not* tested the `certs.verifySignatureECDSAWithSHA1` function as I do not have a certificate with signature algorithm of `ECDSAWithSHA1` to test with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are borrowed from the atc0005/check-cert project where work is underway towards implementing upcoming chain order validation support.
certs.verifySignaturecerts.verifySignatureMD5WithRSAcerts.verifySignatureSHA1WithRSAcerts.verifySignatureECDSAWithSHA1certs.isSelfSignedto drop use of that func and usecerts.verifySignaturehelper func directlycerts.verifySignaturefunc to act as entry point for all signature verification work calling out to algorithm-specific helper functions as needednolint:gosecdirectivesNOTE: I have not tested the
certs.verifySignatureECDSAWithSHA1function as I do not have a certificate with signature algorithm ofECDSAWithSHA1to test with.