Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Compress binaries & use static filenames #470

Closed
atc0005 opened this issue Feb 2, 2023 · 0 comments · Fixed by #486
Closed

Makefile: Compress binaries & use static filenames #470

atc0005 opened this issue Feb 2, 2023 · 0 comments · Fixed by #486
Assignees
@atc0005
Labels
builds dependencies enhancement New feature or request packages Related to generated packages for this project (e.g., RPM, DEB)
Milestone
v0.11.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Feb 2, 2023

Overview

Instead of generating files with this filename format when running make all:

$ tree release_assets/
release_assets/
├── certsum
│   ├── certsum-v0.10.0-2-g8ad7883-linux-386
│   ├── certsum-v0.10.0-2-g8ad7883-linux-386.sha256
│   ├── certsum-v0.10.0-2-g8ad7883-linux-amd64
│   ├── certsum-v0.10.0-2-g8ad7883-linux-amd64.sha256
│   ├── certsum-v0.10.0-2-g8ad7883-windows-386.exe
│   ├── certsum-v0.10.0-2-g8ad7883-windows-386.exe.sha256
│   ├── certsum-v0.10.0-2-g8ad7883-windows-amd64.exe
│   └── certsum-v0.10.0-2-g8ad7883-windows-amd64.exe.sha256
├── check_cert
│   ├── check_cert-v0.10.0-2-g8ad7883-linux-386
│   ├── check_cert-v0.10.0-2-g8ad7883-linux-386.sha256
│   ├── check_cert-v0.10.0-2-g8ad7883-linux-amd64
│   ├── check_cert-v0.10.0-2-g8ad7883-linux-amd64.sha256
│   ├── check_cert-v0.10.0-2-g8ad7883-windows-386.exe
│   ├── check_cert-v0.10.0-2-g8ad7883-windows-386.exe.sha256
│   ├── check_cert-v0.10.0-2-g8ad7883-windows-amd64.exe
│   ├── check_cert-v0.10.0-2-g8ad7883-windows-amd64.exe.sha256
│   └── check_cert_dev
├── lscert
│   ├── lscert-v0.10.0-2-g8ad7883-linux-386
│   ├── lscert-v0.10.0-2-g8ad7883-linux-386.sha256
│   ├── lscert-v0.10.0-2-g8ad7883-linux-amd64
│   ├── lscert-v0.10.0-2-g8ad7883-linux-amd64.sha256
│   ├── lscert-v0.10.0-2-g8ad7883-windows-386.exe
│   ├── lscert-v0.10.0-2-g8ad7883-windows-386.exe.sha256
│   ├── lscert-v0.10.0-2-g8ad7883-windows-amd64.exe
│   └── lscert-v0.10.0-2-g8ad7883-windows-amd64.exe.sha256

Generate in this format instead when running make all:

$ tree release_assets/
release_assets/
├── certsum
│   ├── certsum-linux-386.xz
│   ├── certsum-linux-386.xz.sha256
│   ├── certsum-linux-amd64.xz
│   ├── certsum-linux-amd64.xz.sha256
│   ├── certsum-windows-386.exe.xz
│   ├── certsum-windows-386.exe.xz.sha256
│   ├── certsum-windows-amd64.exe.xz
│   └── certsum-windows-amd64.exe.xz.sha256
├── check_cert
│   ├── check_cert-linux-386.xz
│   ├── check_cert-linux-386.xz.sha256
│   ├── check_cert-linux-amd64.xz
│   ├── check_cert-linux-amd64.xz.sha256
│   ├── check_cert-windows-386.exe.xz
│   ├── check_cert-windows-386.exe.xz.sha256
│   ├── check_cert-windows-amd64.exe.xz
│   └── check_cert-windows-amd64.exe.xz.sha256
├── lscert
│   ├── lscert-linux-386.xz
│   ├── lscert-linux-386.xz.sha256
│   ├── lscert-linux-amd64.xz
│   ├── lscert-linux-amd64.xz.sha256
│   ├── lscert-windows-386.exe.xz
│   ├── lscert-windows-386.exe.xz.sha256
│   ├── lscert-windows-amd64.exe.xz
│   └── lscert-windows-amd64.exe.xz.sha256

Changes:

  • static filenames (without version component)
  • compressed via xz

This is a step towards release automation and simplifying the deployment process.
@atc0005 atc0005 added enhancement New feature or request builds labels Feb 2, 2023
@atc0005 atc0005 added this to the Next Release milestone Feb 2, 2023
@atc0005 atc0005 self-assigned this Feb 2, 2023
@atc0005 atc0005 changed the title Update Makefile: compress binaries & use static filenames Update Makefile: Compress binaries & use static filenames Feb 2, 2023
@atc0005 atc0005 added the packages Related to generated packages for this project (e.g., RPM, DEB) label Feb 2, 2023
atc0005 added a commit that referenced this issue Feb 7, 2023
@atc0005
Makefile: Compress binaries & use static filenames
d7b0b59 
- split arch/os-specific recipes into separate tasks
  - building assets
  - creating checksum files for assets
  - compressing assets (NEW)
- formatting tweaks to output
  - lowercase subtasks
  - minor tweaks to "completed" messages to better match specific
    recipe (e.g., don't say "build" for non-build tasks)
- rework package build and release-build recipes to share work
  - don't rebuild assets
  - postpone generating download links until all assets are available
- update README
  - note replacement Makefile recipes to achieve previous
    functionality (sans checksum files)
  - note need to decompress (compressed) binaries before deploying
    them
  - note optional DEB and RPM packages in lieu of manually deploying
    binaries

refs GH-470
@atc0005 atc0005 mentioned this issue Feb 7, 2023
Merged
atc0005 added a commit that referenced this issue Feb 7, 2023
@atc0005
Makefile: Compress binaries & use static filenames
0e80631 
- split arch/os-specific recipes into separate tasks
  - building assets
  - creating checksum files for assets
  - compressing assets (NEW)
- formatting tweaks to output
  - lowercase subtasks
  - minor tweaks to "completed" messages to better match specific
    recipe (e.g., don't say "build" for non-build tasks)
- rework package build and release-build recipes to share work
  - don't rebuild assets
  - postpone generating download links until all assets are available
- update README
  - note replacement Makefile recipes to achieve previous
    functionality (sans checksum files)
  - note need to decompress (compressed) binaries before deploying
    them
  - note optional DEB and RPM packages in lieu of manually deploying
    binaries

refs GH-470
@atc0005 atc0005 changed the title Update Makefile: Compress binaries & use static filenames Makefile: Compress binaries & use static filenames Feb 9, 2023
@atc0005 atc0005 mentioned this issue Mar 5, 2023
Closed
This was referenced Mar 5, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 9, 2023
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 14, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
builds dependencies enhancement New feature or request packages Related to generated packages for this project (e.g., RPM, DEB)
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

Makefile: Compress binaries & use static filenames atc0005/check-cert
1 participant
@atc0005