Clarify CertChainValidationResult output control #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `CertChainValidationResult` interface doc comments to clarify that implementations should not rely on leading/trailing whitespace to be retained in output for `Status`, `Overview`, `StatusDetail`, `String` and `Report` method output. Update `CertChainValidationResults.Report` method to explicitly trim leading/trailing whitespace in called `Report` method and add explicit trailing `nagios.CheckOutputEOL` value.
atc0005
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
CertChainValidationResultinterface doc comments to clarify that implementations should not rely onleading/trailing whitespace to be retained in output for
Status,Overview,StatusDetail,StringandReportmethod output.Update
CertChainValidationResults.Reportmethod to explicitly trim leading/trailing whitespace in calledReportmethod and add explicit trailingnagios.CheckOutputEOLvalue.