Add support for binary DER format cert files #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES
- update README file to list additional supported cert
file input format
- `internal/textutils` package
- add EOL constants
- add "normalize" functions
- `NormalizeNewlines`
- `StripBlankLines`
- `StripBlankAndNormalize`
- `internal/certs` package
- add new sentinel errors
- `ErrUnsupportedFileFormat`
- `ErrEmptyCertificateFile`
- `ErrPEMParseFailureMalformedCertificate`
- `ErrPEMParseFailureEmptyCertificateBlock`
- add (24) new PEM block type contants
- e.g., `PEMBlockTypeCRTBegin`
- update `GetCertsFromFile` function to act as an entry point for
loading certificates from a given file for all supported formats
instead of being dedicated strictly to PEM formatted certificate
files
- continue to support importing (text) PEM encoded format
- add support for importing binary DER encoded format
- detect common unsupported PEM encoded file formats so that we
can list the given file as being of a specific unsupported file
format
- refactor bulk of PEM handling logic originally contained in
`GetCertsFromFile` to separate functions
- `GetCertsFromPEMFile`
- `ParsePEMCertificates`
REFERENCES
refs GH-862
atc0005
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
internal/textutilspackageNormalizeNewlinesStripBlankLinesStripBlankAndNormalizeinternal/certspackageErrUnsupportedFileFormatErrEmptyCertificateFileErrPEMParseFailureMalformedCertificateErrPEMParseFailureEmptyCertificateBlockPEMBlockTypeCRTBeginGetCertsFromFilefunction to act as an entry point for loading certificates from a given file for all supported formats instead of being dedicated strictly to PEM formatted certificate filesGetCertsFromFileto separate functionsGetCertsFromPEMFileParsePEMCertificatesReferences