Update lscert hostname validation behavior
#977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update hostname validation logic to ignore the result if a leaf certificate is not present in the given certificate chain OR if the `dns-name` flag was not used. Add a slight addendum/note explaining what is needed (if a leaf cert is present) or that the check is unsupported (if no leaf cert is present). Add new functions to the `internal/certs` package to quickly answer whether any certificate of the specified type is present within a given certificate chain: - `HasLeafCert` - `HasIntermediateCert` - `HasRootCert` refs GH-952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update hostname validation logic to ignore the result if a leaf certificate is not present in the given certificate chain OR if the
dns-nameflag was not used. Add a slight addendum/note explaining what is needed (if a leaf cert is present) or that the check is unsupported (if no leaf cert is present).Add new functions to the
internal/certspackage to quickly answer whether any certificate of the specified type is present within a given certificate chain:HasLeafCertHasIntermediateCertHasRootCertReferences