Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var-declaration linting errors from revive linter #267

Closed
atc0005 opened this issue Feb 4, 2022 · 0 comments · Fixed by #268
Closed

var-declaration linting errors from revive linter #267

atc0005 opened this issue Feb 4, 2022 · 0 comments · Fixed by #268
Assignees
Labels
bug Something isn't working linting
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented Feb 4, 2022

Surfaced by #266:

internal/textutils/inspect_test.go:23:20: var-declaration: should drop = nil from declaration of var want; it is the zero value (revive)
		var want error = nil
		                 ^
internal/textutils/inspect_test.go:42:20): var-declaration: should drop = nil from declaration of var want; it is the zero value (revive)
		var want error = nil
		                 ^
internal/config/config.go:23:13: var-declaration: should omit type string from declaration of var version; it will be inferred from the right-hand side (revive)
var version string = "x.y.z"
            ^
@atc0005 atc0005 added bug Something isn't working linting labels Feb 4, 2022
@atc0005 atc0005 added this to the Next Release milestone Feb 4, 2022
@atc0005 atc0005 self-assigned this Feb 4, 2022
atc0005 added a commit that referenced this issue Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant