Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

err113: do not compare errors directly "got != want", use "!errors.Is(got, want)" #274

Closed
atc0005 opened this issue Mar 2, 2022 · 0 comments · Fixed by #279
Closed

err113: do not compare errors directly "got != want", use "!errors.Is(got, want)" #274

atc0005 opened this issue Mar 2, 2022 · 0 comments · Fixed by #279
Assignees
@atc0005
Labels
bug Something isn't working linting
Milestone
v0.4.16

Comments

@atc0005
Copy link
Owner

atc0005 commented Mar 2, 2022 

internal/textutils/inspect_test.go:26:6: err113: do not compare errors directly "got != want", use "!errors.Is(got, want)" instead (goerr113)
		if got != want {
		   ^
internal/textutils/inspect_test.go:45:6: err113: do not compare errors directly "got != want", use "!errors.Is(got, want)" instead (goerr113)
		if got != want {
		   ^
@atc0005 atc0005 added bug Something isn't working linting labels Mar 2, 2022
@atc0005 atc0005 added this to the Next Release milestone Mar 2, 2022
@atc0005 atc0005 self-assigned this Mar 2, 2022
atc0005 added a commit that referenced this issue Apr 27, 2022
@atc0005
Use errors.Is() to replace direct errors compare
e670e14 
Fix err113 linter warning re comparing errors directly
by using `errors.Is()` in tests.

refs GH-274
@atc0005 atc0005 mentioned this issue Apr 27, 2022
Merged
atc0005 added a commit that referenced this issue Apr 27, 2022
@atc0005
Use errors.Is() to replace direct errors compare
73e746e 
Fix err113 linter warning re comparing errors directly
by using `errors.Is()` in tests.

refs GH-274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working linting
Projects
None yet
Milestone
v0.4.16
Development

Successfully merging a pull request may close this issue.

Use errors.Is() to replace direct errors compare atc0005/check-mail
1 participant
@atc0005