Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile build cmd to create static binaries #95

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Oct 3, 2020

Fix Makefile build cmd to create static binaries

The previous build command produces dynamic executables
instead of the intended (but not well noted in the Makefile)
static executables. This commit includes changes noted in
upstream golang/go issues which appear to work as intended
for others.

I also include doc comments and reference links describing
the use of the updated build options list and some problems
that I encountered during testing of linkmode=external.

@atc0005 atc0005 added bug Something isn't working builds labels Oct 3, 2020
@atc0005 atc0005 added this to the v0.2.5 milestone Oct 3, 2020
@atc0005 atc0005 self-assigned this Oct 3, 2020
The previous build command produces dynamic executables
instead of the intended (but not well noted in the Makefile)
static executables. This commit includes changes noted in
upstream `golang/go` issues which appear to work as intended
for others.

I also include doc comments and reference links describing
the use of the updated build options list and some problems
that I encountered during testing of `linkmode=external`.

- refs GH-94
- refs golang/go 38789
- refs golang/go 26492
@atc0005 atc0005 force-pushed the i94-update-makefile-build-command-to-generate-static-binaries branch from 43a5535 to 47e1f1b Compare October 3, 2020 13:53
@atc0005
Copy link
Owner Author

atc0005 commented Oct 3, 2020

Note: I can't say for sure whether the options included in this project's Makefile will be safe to export to other projects (e.g., atc0005/mysql2sqlite).

@atc0005 atc0005 merged commit d0d20f4 into master Oct 3, 2020
@atc0005 atc0005 deleted the i94-update-makefile-build-command-to-generate-static-binaries branch October 3, 2020 13:59
@atc0005 atc0005 added the license label Oct 6, 2020
atc0005 added a commit to atc0005/check-cert that referenced this pull request Oct 7, 2020
The previous build command produces dynamic executables
instead of the intended (but not well noted in the Makefile)
static executables. This commit includes changes noted in
upstream `golang/go` issues which appear to work as intended
for others.

I also include doc comments and reference links describing
the use of the updated build options list and some problems
that I encountered during testing of `linkmode=external`.

- refs GH-92

- refs atc0005/check-mail#94
- refs atc0005/check-mail#95
- refs atc0005/check-mail#101

- refs golang/go 38789
- refs golang/go 26492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builds license
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile build options do not generate static binaries
1 participant