Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vuln analysis GHAW to remove on.push hook #99

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Jun 9, 2023

This hook was previously needed for proper operation of the Vulnerability / CodeQL job so that it could compare before/after changes against the base branch.

This requirement was removed as part of recent work in the github/codeql-action project.

I'm keeping the event type check for jobs already using it for the time being.

refs atc0005/todo#60

This hook was previously needed for proper operation of the
`Vulnerability / CodeQL` job so that it could compare before/after
changes against the base branch.

This requirement was removed as part of recent work in the
github/codeql-action project.

I'm keeping the event type check for jobs already using it for the
time being.

refs atc0005/todo#60
@atc0005 atc0005 added enhancement New feature or request CI labels Jun 9, 2023
@atc0005 atc0005 added this to the Next Release milestone Jun 9, 2023
@atc0005 atc0005 self-assigned this Jun 9, 2023
@atc0005 atc0005 merged commit 00c02c2 into master Jun 9, 2023
@atc0005 atc0005 deleted the remove-push-event-hook-from-vuln-anaylsis-workflow branch June 9, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant