-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand linting GitHub Actions Workflow to include oldstable
, unstable
container images
#206
Comments
atc0005
added a commit
that referenced
this issue
Feb 1, 2022
Use the same matrix of containers for linting in the `Validate Codebase` GHAW that we're already using for testing and building jobs. This applies the minimum linting requirements in addition to testing "unstable" linting options that may become the new baseline in the future. refs GH-206
atc0005
added a commit
that referenced
this issue
Feb 1, 2022
Use the same matrix of containers for linting in the `Validate Codebase` GHAW that we're already using for testing and building jobs. This applies the minimum linting requirements in addition to testing "unstable" linting options that may become the new baseline in the future. refs GH-206
atc0005
added a commit
that referenced
this issue
Feb 1, 2022
Use the same matrix of containers for linting in the `Validate Codebase` GHAW that we're already using for testing and building jobs. This applies the minimum linting requirements in addition to testing "unstable" linting options that may become the new baseline in the future. refs GH-206
atc0005
added a commit
that referenced
this issue
Feb 1, 2022
Use the same matrix of containers for linting in the `Validate Codebase` GHAW that we're already using for testing and building jobs. This applies the minimum linting requirements in addition to testing "unstable" linting options that may become the new baseline in the future. refs GH-206
atc0005
added a commit
that referenced
this issue
Feb 1, 2022
Use the same matrix of containers for linting in the `Validate Codebase` GHAW that we're already using for testing and building jobs. This applies the minimum linting requirements in addition to testing "unstable" linting options that may become the new baseline in the future. refs GH-206
atc0005
added a commit
that referenced
this issue
Feb 1, 2022
Use the same matrix of containers for linting in the `Validate Codebase` GHAW that we're already using for testing and building jobs. This applies the minimum linting requirements in addition to testing "unstable" linting options that may become the new baseline in the future. One notable difference is that out of the matrix of containers used for linting we mark the unstable container as "experimental" and configure the job to ignore linting errors generated by that container. This effectively makes any linting output from the unstable container informational only as intended. refs GH-206
atc0005
changed the title
Add GitHub Actions Workflow for linting code using
Expand GitHub Actions Workflow for linting code to include Feb 1, 2022
unstable
containeroldstable
, unstable
container images
atc0005
changed the title
Expand GitHub Actions Workflow for linting code to include
Expand linting GitHub Actions Workflow to include Feb 1, 2022
oldstable
, unstable
container imagesoldstable
, unstable
container images
This was referenced Feb 4, 2022
This was referenced Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the code is linted using the "stable"
index.docker.io/atc0005/go-ci:go-ci-lint-only
container in two different workflows:send2teams/.github/workflows/lint-and-test-only.yml
Lines 8 to 22 in 171c451
send2teams/.github/workflows/lint-and-build-code.yml
Lines 8 to 24 in 171c451
The first workflow is meant as a quick validation check (linting & tests) on push. The second, more comprehensive workflow is used on pull requests only and applies linting, test & build jobs. The tests and builds are performed using three different containers:
oldstable
stable
unstable
I plan to extend this second workflow to also use the
unstable
image in linting checks. I don't yet see the value in linting using theoldstable
image also, but will include it also just to "cover the bases".Based on recent GHAW runs, I expect that the
unstable
image will generate numerous linting complaints as I test out more strict linting options in that image. Based on this, I will refrain from setting linting results for that container as required "OK" before allowing merges. This may require adding a second GHAW job to run the linting checks using that container so that the existingValidate Codebase
results remain unaffected (this GHAW is required to pass).The text was updated successfully, but these errors were encountered: