fix misc layout issues #2282
Merged
fix misc layout issues #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filipesilva
requested changes
Aug 16, 2022
There was a problem hiding this comment.
Slash command seems to get into a weird position sometimes:
This was ok
But calling it on the second daily note shows it in a different place:
After calling and dismissing it on the first daily note, hovering around the note shows the menu from the top left corner
| const { children, rightSidebarWidth, isOpen } = props; | ||
|
|
||
| console.log(rightSidebarWidth) |
There was a problem hiding this comment.
Nit: remove debug code
filipesilva
approved these changes
Aug 17, 2022
| } from '@chakra-ui/react'; | ||
| import getCaretCoordinates from '@/../textarea' | ||
| import getCaretCoordinates from 'textarea-caret'; |
There was a problem hiding this comment.
Of course there's a npm lib for this.
It seems to be doing what our code was, but without us having to maintain it. Awesome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major
Minor