feat: v1 queries table view for tasks #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* feat: readable table query * fix: clearer style for disabled taskbox * improvement: neater query table
* feat: readable table query * fix: clearer style for disabled taskbox * improvement: neater query table * feat: block in row toggle and children counter * feat: block in row toggle and children counter * feat: more goodies in query table
tangjeff0
commented
Sep 6, 2022
Comment on lines
532
to
+540
| (defn handle-escape | ||
| "BUG: escape is fired 24 times for some reason." | ||
| [uid e] | ||
| [e uid {:keys [esc-handler] :as _state-hooks}] | ||
| (.. e preventDefault) | ||
| (if @(rf/subscribe [::inline-search.subs/type uid]) | ||
| (rf/dispatch [::inline-search.events/close! uid]) | ||
| (dispatch [:editing/uid nil]))) | ||
| (if (fn? esc-handler) | ||
| (esc-handler e uid) | ||
| (if @(rf/subscribe [::inline-search.subs/type uid]) | ||
| (rf/dispatch [::inline-search.events/close! uid]) | ||
| (dispatch [:editing/uid nil])))) |
There was a problem hiding this comment.
I added an esc-handler for some of task title editors on kanban and table views. In those cases, esc should cancel the title edit, and blurring should save. Wanted to bring this to your attention @neotyk to double-check this is an ok way to do things
tangjeff0
commented
Sep 6, 2022
Comment on lines
430
to
+442
| (defn get-entity-type | ||
| "Returns the value of eids `:entity/type` prop, if any." | ||
| [db eid] | ||
| (->> (d/entity db eid) | ||
| :block/_property-of | ||
| (some (fn [e] | ||
| (when (-> e :block/key :node/title (= ":entity/type")) | ||
| (:block/string e)))))) | ||
| (let [prop-entity-type (->> (d/entity db eid) | ||
| :block/_property-of | ||
| (some (fn [e] | ||
| (when (-> e :block/key :node/title (= ":entity/type")) | ||
| (:block/string e))))) | ||
| page (get-page-title-from-eid db eid)] | ||
| (cond | ||
| prop-entity-type prop-entity-type | ||
| page "page" | ||
| :else "block"))) |
There was a problem hiding this comment.
This is a sort of centralized type aggregator / schema.
tangjeff0
commented
Sep 6, 2022
Comment on lines
430
to
+442
| (defn get-entity-type | ||
| "Returns the value of eids `:entity/type` prop, if any." | ||
| [db eid] | ||
| (->> (d/entity db eid) | ||
| :block/_property-of | ||
| (some (fn [e] | ||
| (when (-> e :block/key :node/title (= ":entity/type")) | ||
| (:block/string e)))))) | ||
| (let [prop-entity-type (->> (d/entity db eid) | ||
| :block/_property-of | ||
| (some (fn [e] | ||
| (when (-> e :block/key :node/title (= ":entity/type")) | ||
| (:block/string e))))) | ||
| page (get-page-title-from-eid db eid)] | ||
| (cond | ||
| prop-entity-type prop-entity-type | ||
| page "page" | ||
| :else "block"))) |
There was a problem hiding this comment.
This is a sort of centralized type aggregator / schema @sid597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can edit title, shows derived hierarchy if it exists, etc. Can't edit other fields yet, while Stuart is working on picker component.