Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show title on blocks too #2376

Merged
merged 4 commits into from
Sep 24, 2022

Conversation

shanberg
Copy link
Collaborator

Before, only pages contributed a title to the toolbar.
Now blocks and routes (e.g. Daily Notes, Graph) will too.

@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
athens ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 6:41PM (UTC)

Copy link
Collaborator

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is working for blocks:
image

@shanberg
Copy link
Collaborator Author

I don't think this is working for blocks:

image

It should only appear after you've scrolled down and the native title is offscreen, otherwise it’s redundant. Is that not happening?

@shanberg shanberg merged commit e193dd2 into athensresearch:main Sep 24, 2022
@shanberg shanberg deleted the show-title-on-blocks-too branch September 25, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants