-
Notifications
You must be signed in to change notification settings - Fork 388
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
On Windows, MRI Ruby uses the `FindFirstFileW` et. al. kind of functions with wide character paths and constantly converts from multi-byte to wide character encoding back and forth when calling any methods on `File` or `Dir`. This means that when using `Encoding::ASCII_8BIT` for reading directory entries, that this does not round trip properly, if a file name contains unicode characters. That is because Ruby assumes the path string is encoded in Windows Codepage 1252[1]. * skip symlink test if files were checked out from git as textual symlinks on Windows * use UTF-8 encoding on Windows, since this properly round-trips between multi-byte and wide character encoding * travis: windows job no longer is allowed to fail [1]: https://github.com/ruby/ruby/blob/946cd6c5348d7dd12ecc41e79c3ca9803d2ca7f0/win32/file.c#L131-L134
- Loading branch information
Showing
3 changed files
with
21 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,6 @@ jobs: | |
|
||
allow_failures: | ||
- rvm: truffleruby-head | ||
- os: windows | ||
|
||
include: | ||
- os: osx | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters