-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the option to handle depth for the tree flag #253
Add the option to handle depth for the tree flag #253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 84.37% 84.52% +0.14%
==========================================
Files 7 7
Lines 416 420 +4
==========================================
+ Hits 351 355 +4
Misses 65 65
Continue to review full report at Codecov.
|
Should I create a function for the new behaviour? About the increment of the variable on the loop I already re-write that part |
No, let's not duplicate the code. Just use Also, could you add a test case in And add an example call to the travis.yml file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, the PR is almost ready to merge. Could you fix the two minor issues, please?
Thank you for your first contribution! 🎉 |
* Add the option to handle depth for the tree flag * Update README to describe the new option for the tree flag * Add tests
Introduction
Hi, I really like this gem, I was customising terminal and then, one day, I found myself running this in one of my personal projects with a lot of folders and I was surprised that nobody already fixed this so I wanted to improve in this part of the gem.
I'm not a full time ruby dev but I like to learn, Im open for suggestions and ideas 😃
Description
This pull request includes:
There's some work to be done to consider this as finished since I made one assumption that I want to clarify.
I need to check the other options/flags on the README to avoid cases as with "-t"
Note: Don't mind the missing icons on the gif. I'm learning how to use/customize that tool too 😅