Handle git status for . and .. properly
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
The git status is only computed for the given directory and is stored as a Hash mapping relative paths to their mode string. For a directory, the git status is comprised of all the statuses of its files itself and all its sub directories. The current directory's prefix is just an empty string matching all files inside the `@git_status` Hash. Asking for the status of the parent directory is pointless, we do not compute it (yet).
I do not want to use `warn` since these errors should not be suppressed. And I always want to use `STDERR`, not `$stderr`.
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
=========================================
- Coverage 86.11% 85.71% -0.4%
=========================================
Files 7 7
Lines 432 434 +2
=========================================
Hits 372 372
- Misses 60 62 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a small regression introduced with #268 where the git status of
.and..reported with--git-statuswould be wrong.