Do not exit if locale settings are broken #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdv
force-pushed
the
rescue-setlocale
branch
from
efdf3ce
to
96334da
Compare
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
=========================================
+ Coverage 88.75% 88.8% +0.04%
=========================================
Files 8 8
Lines 498 500 +2
=========================================
+ Hits 442 444 +2
Misses 56 56
Continue to review full report at Codecov.
|
avdv
force-pushed
the
rescue-setlocale
branch
from
96334da
to
dbf23ca
Compare
avdv
force-pushed
the
rescue-setlocale
branch
2 times, most recently
from
4fb29b0
to
8a675e4
Compare
Keep running if calling `setlocale` fails, because of invalid locale settings. Fixes athityakumar#335.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were a few reports about colorls error-out with broken locale settings (especially on OSX).
To crash is rather extreme, if nothing bad can happen if calling
setlocalefails. It's just sorting the filenames will happen to use the C locale rules.Simply warning the user that something bad has happened and carry on.