Fix encoding error for non UTF-8 locale #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdv
force-pushed
the
fix-352
branch
2 times, most recently
from
71d0091
to
56d3a1f
Compare
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
- Coverage 88.75% 87.99% -0.77%
==========================================
Files 8 8
Lines 498 508 +10
==========================================
+ Hits 442 447 +5
- Misses 56 61 +5
Continue to review full report at Codecov.
|
On Unix systems the encoding of file names is specified by the user via the locale settings. In order to avoid encoding problems simply read file names in ASCII 8 bit encoding and try to convert to the external encoding while replacing undefined characters. Also, does not show an icon if the external encoding does not support it and shows a `=` instead of a check mark for git status. Fixes athityakumar#352.
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the user misconfigures the locale and thus the wrong encoding is used to interpret file names, we might run into an encoding problem later.
Also, if the encoding is not capable of handling unicode symbols, we should not display icons and replace undefined characters with a replacement character.