Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 2.4 #354

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Drop support for Ruby 2.4 #354

merged 2 commits into from
Apr 16, 2020

Conversation

avdv
Copy link
Collaborator

@avdv avdv commented Apr 16, 2020

Description

Ruby 2.4 has reached EOL, there are no longer security patches.

  • Relevant Issues : (none)
  • Relevant PRs : (none)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

```
The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file:
 - Lint/RaiseException (0.81)
 - Lint/StructNewOverride (0.81)
 - Style/HashEachMethods (0.80)
 - Style/HashTransformKeys (0.80)
 - Style/HashTransformValues (0.80)
For more information: https://docs.rubocop.org/en/latest/versioning/
```
@codecov-io
Copy link

codecov-io commented Apr 16, 2020

Codecov Report

Merging #354 into master will decrease coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
- Coverage   87.99%   87.95%   -0.05%     
==========================================
  Files           8        8              
  Lines         508      498      -10     
==========================================
- Hits          447      438       -9     
+ Misses         61       60       -1     
Impacted Files Coverage Δ
lib/colorls/monkeys.rb 84.61% <ø> (-5.39%) ⬇️
lib/colorls/flags.rb 87.17% <80.00%> (-0.11%) ⬇️
lib/colorls/core.rb 88.58% <0.00%> (-0.06%) ⬇️
lib/colorls/git.rb 72.41% <0.00%> (+2.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1234d82...9d073af. Read the comment docs.

It reached EOL on March 31, 2020, and no longer receives patches.

See https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/
@avdv avdv merged commit 2afd28b into athityakumar:master Apr 16, 2020
@avdv avdv deleted the drop-ruby-2.4 branch April 16, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants