Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows to build matrix #358

Merged
merged 1 commit into from
Sep 26, 2020
Merged

Add Windows to build matrix #358

merged 1 commit into from
Sep 26, 2020

Conversation

avdv
Copy link
Collaborator

@avdv avdv commented May 10, 2020

Description

The goal here is to have a working windows build environment and fix things later if tests break.

  • Relevant Issues : (none)
  • Relevant PRs : (none)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #358 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   88.77%   88.82%   +0.04%     
==========================================
  Files           8        8              
  Lines         508      501       -7     
==========================================
- Hits          451      445       -6     
+ Misses         57       56       -1     
Impacted Files Coverage Δ
lib/colorls/core.rb 89.95% <0.00%> (-0.10%) ⬇️
lib/colorls/flags.rb 88.33% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21cf5d4...61e19df. Read the comment docs.

.travis.yml Outdated
- choco install msys2
- find /c/ -iname ridk\*
#- Update-SessionEnvironment # refresh environment vars
- cmd /c 'c:\tools\ruby27\bin\ridk.cmd' install dev_tools
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- cmd /c 'c:\tools\ruby27\bin\ridk.cmd' install dev_tools
- cmd /c '"c:\tools\ruby27\bin\ridk.cmd install dev_tools"'

@avdv avdv force-pushed the windows-build branch 2 times, most recently from adf4818 to c2f03d1 Compare September 26, 2020 08:55
@avdv avdv marked this pull request as ready for review September 26, 2020 09:15
@avdv avdv merged commit 87c48e4 into athityakumar:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants