Fix unrecognized files count and colorization #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A *file* is assigned a generic icon / glyph in `files.yaml`, so looking up `:file` in the corresponding hash always succeeds, but `:file` is also used as the fallback key if a file's extension is not recognized. First determining the color and group of a given file before falling back to the `:file` key fixes this issue.
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
==========================================
+ Coverage 88.02% 88.62% +0.59%
==========================================
Files 8 8
Lines 501 501
==========================================
+ Hits 441 444 +3
+ Misses 60 57 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A file is assigned a generic icon / glyph in
files.yaml, so looking up:filein the corresponding hash always succeeds, but:fileis also used asthe fallback key if a file's extension is not recognized.
First determining the color and group of a given file before falling back to
the
:filekey fixes this issue.Description
Thanks for contributing this Pull Request. Add a brief description of what this Pull Request does. Do tag the relevant issue(s) and PR(s) below. If required, add some screenshot(s) to support your changes.