Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for executable_file color #447

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

FelixDombek-TomTom
Copy link

Add support for executable_file color

I find the default handling of executables (just printing them in bold) too subtle. To be able to make them stand out more, they can now be colored in a user-defined color.

  • Relevant Issues : (none)
  • Relevant PRs : (none)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation
      image

Copy link
Collaborator

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@avdv avdv merged commit d08ec7a into athityakumar:master Mar 5, 2021
@mzjp2
Copy link

mzjp2 commented Mar 13, 2021

Thought it'd be worth mentioning that I updated my colorls and was unpleasantly surprised to see my colour scheme changed (all my files were now yellow-orange-ish instead of lime). I hunted this PR down and swapped the lime/yellow colors here to get back to the default theme. What was the rationale for this "breaking" change instead of making the executable file color yellow?

@FelixDombek-TomTom
Copy link
Author

Sorry for that experience. My rationale for proposing it this way, and having it like this myself after some trying around, is that the known/unknown files are more similar to each other in kind than either is to an executable file. For example, in the default settings used for the screenshot above, .c is known while .h isn't; using a color for executables that is arguably closer to the unknown file color looked very weird to me. I assumed that many would want this fixed; maybe that was uncalled for.

@mzjp2
Copy link

mzjp2 commented Mar 15, 2021

I see - that makes sense. Thanks for the explanation. Wasn't a big deal on my side (and is probably just my weird aesthetics!) 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants