Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 1.11.0 to ~> 1.12.0 #451

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.12

New features

  • #9615: Add new Style/StringChars cop. (@koic)
  • #9629: Add AllowParenthesesInStringInterpolation configuration to Style/MethodCallWithArgsParentheses to allow parenthesized calls in string interpolation. (@gsamokovarov)
  • #9219: Allow excluding some constants from Style/Documentation. (@fsateler)
  • Add AllowNil option for Lint/SuppressedException to allow/disallow rescue nil. (@corroded)

Bug fixes

  • #9560: Fix an error for Lint/ClassMethodsDefinitions when defining class methods with class << self with comment only body. (@koic)
  • #9551: Fix a false positive for Style/UnlessLogicalOperators when using || operator and invoked method name includes "or" in the conditional branch. (@koic)
  • #9620: Allow parentheses in operator methods calls for Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses. (@gsamokovarov)
  • #9622: Fixed Style/BisectedAttrAccessor autocorrection to handle multiple bisected attrs in the same macro. (@dvandersluis)
  • #9606: Fix an error for Layout/IndentationConsistency when using access modifier at the top level. (@koic)
  • #9619: Fix infinite loop between Layout/IndentationWidth and Layout/RescueEnsureAlignment autocorrection. (@dvandersluis)
  • #9633: Fix an incorrect auto-correct for Lint/NumberConversion when to_i method in symbol form. (@koic)
  • #9616: Fix an incorrect auto-correct for Style/EvalWithLocation when using #instance_eval with a string argument in parentheses. (@koic)
  • #9429: Fix Style/NegatedIfElseCondition autocorrect to keep comments in correct branch. (@tejasbubane)
  • #9631: Fix an incorrect auto-correct for Style/RedundantReturn when using return with splat argument. (@koic)
  • #9627: Fix an incorrect auto-correct for Style/StructInheritance when extending instance of Struct without do ... end and class body is empty. (@koic)
  • #5953: Fix a false positive for Style/AccessModifierDeclarations when using module_function with symbol. (@koic)
  • #9593: Fix an error when processing a directory is named {}. (@koic)
  • #9599: Fix an error for Style/CaseLikeIf when using include? without a receiver. (@koic)
  • #9582: Fix incorrect auto-correct for Style/ClassEqualityComparison when comparing Module#name for equality. (@koic)
  • #9603: Fix a false positive for Style/SoleNestedConditional when using nested modifier on value assigned in condition. (@koic)
  • #9598: Fix RuboCop::MagicComment#valid_shareable_constant_value?. (@kachick)
  • #9625: Allow parentheses in yield arguments with Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses to fix invalid Ruby auto-correction. (@gsamokovarov)
  • #9558: Fix inconsistency when dealing with URIs that are wrapped in single quotes vs double quotes. (@dvandersluis)
  • #9613: Fix a false positive for Style/RedundantSelf when a self receiver on an lvalue of mlhs arguments. (@koic)
  • #9586: Update Naming/RescuedExceptionsVariableName to not register on inner rescues when nested. (@dvandersluis)

Changes

  • #9487: Mark Naming/MemoizedInstanceVariableName as unsafe. (@marcandre)
  • #9601: Make Style/RedundantBegin aware of redundant begin/end blocks around memoization. (@koic)
  • #9617: Disable suggested extensions when using the --stdin option. (@dvandersluis)
Changelog

Sourced from rubocop's changelog.

1.12.0 (2021-03-24)

New features

  • #9615: Add new Style/StringChars cop. ([@koic][])
  • #9629: Add AllowParenthesesInStringInterpolation configuration to Style/MethodCallWithArgsParentheses to allow parenthesized calls in string interpolation. ([@gsamokovarov][])
  • #9219: Allow excluding some constants from Style/Documentation. ([@fsateler][])
  • Add AllowNil option for Lint/SuppressedException to allow/disallow rescue nil. ([@corroded][])

Bug fixes

  • #9560: Fix an error for Lint/ClassMethodsDefinitions when defining class methods with class << self with comment only body. ([@koic][])
  • #9551: Fix a false positive for Style/UnlessLogicalOperators when using || operator and invoked method name includes "or" in the conditional branch. ([@koic][])
  • #9620: Allow parentheses in operator methods calls for Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses. ([@gsamokovarov][])
  • #9622: Fixed Style/BisectedAttrAccessor autocorrection to handle multiple bisected attrs in the same macro. ([@dvandersluis][])
  • #9606: Fix an error for Layout/IndentationConsistency when using access modifier at the top level. ([@koic][])
  • #9619: Fix infinite loop between Layout/IndentationWidth and Layout/RescueEnsureAlignment autocorrection. ([@dvandersluis][])
  • #9633: Fix an incorrect auto-correct for Lint/NumberConversion when to_i method in symbol form. ([@koic][])
  • #9616: Fix an incorrect auto-correct for Style/EvalWithLocation when using #instance_eval with a string argument in parentheses. ([@koic][])
  • #9429: Fix Style/NegatedIfElseCondition autocorrect to keep comments in correct branch. ([@tejasbubane][])
  • #9631: Fix an incorrect auto-correct for Style/RedundantReturn when using return with splat argument. ([@koic][])
  • #9627: Fix an incorrect auto-correct for Style/StructInheritance when extending instance of Struct without do ... end and class body is empty. ([@koic][])
  • #5953: Fix a false positive for Style/AccessModifierDeclarations when using module_function with symbol. ([@koic][])
  • #9593: Fix an error when processing a directory is named {}. ([@koic][])
  • #9599: Fix an error for Style/CaseLikeIf when using include? without a receiver. ([@koic][])
  • #9582: Fix incorrect auto-correct for Style/ClassEqualityComparison when comparing Module#name for equality. ([@koic][])
  • #9603: Fix a false positive for Style/SoleNestedConditional when using nested modifier on value assigned in condition. ([@koic][])
  • #9598: Fix RuboCop::MagicComment#valid_shareable_constant_value?. ([@kachick][])
  • #9625: Allow parentheses in yield arguments with Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses to fix invalid Ruby auto-correction. ([@gsamokovarov][])
  • #9558: Fix inconsistency when dealing with URIs that are wrapped in single quotes vs double quotes. ([@dvandersluis][])
  • #9613: Fix a false positive for Style/RedundantSelf when a self receiver on an lvalue of mlhs arguments. ([@koic][])
  • #9586: Update Naming/RescuedExceptionsVariableName to not register on inner rescues when nested. ([@dvandersluis][])

Changes

  • #9487: Mark Naming/MemoizedInstanceVariableName as unsafe. ([@marcandre][])
  • #9601: Make Style/RedundantBegin aware of redundant begin/end blocks around memoization. ([@koic][])
  • #9617: Disable suggested extensions when using the --stdin option. ([@dvandersluis][])

1.11.0 (2021-03-01)

New features

  • #5388: Add new Style/UnlessLogicalOperators cop. ([@caalberts][])
  • #9525: Add AllowMethodsWithArguments option to Style/SymbolProc. ([@koic][])

Bug fixes

  • #9520: Fix an incorrect auto-correct for Style/MultipleComparison when comparing a variable with multiple items in if and elsif conditions. ([@koic][])
  • #9548: Fix a false positive for Style/TrailingBodyOnMethodDefinition when endless method definition body is after newline in opening parenthesis. ([@koic][])

... (truncated)

Commits
  • fa02e85 Cut 1.12
  • 50650dd Update Changelog
  • 56d645d [Fix #9622] Fixed Style/BisectedAttrAccessor autocorrection to handle multi...
  • 211c017 Merge pull request #9632 from koic/fix_a_false_positive_for_style_access_modi...
  • 107624a Merge pull request #9633 from koic/fix_incorrect_autocorrect_for_lint_number_...
  • ee40857 Fix an incorrect auto-correct for Lint/NumberConversion
  • c5913b3 [Fix #5953] Fix a false positive for Style/AccessModifierDeclarations
  • 98ff684 Refactor CommentConfig
  • 5125284 [Fix #9621] Add consistent style to Lint/SymbolConversion to require all ...
  • 8535e32 Fix an incorrect auto-correct for Style/RedundantReturn
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.11.0...v1.12.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Mar 24, 2021
@codecov-io
Copy link

codecov-io commented Mar 24, 2021

Codecov Report

Merging #451 (3a7552c) into master (442eca4) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   88.65%   88.50%   -0.15%     
==========================================
  Files           8        8              
  Lines         564      557       -7     
==========================================
- Hits          500      493       -7     
  Misses         64       64              
Impacted Files Coverage Δ
lib/colorls/flags.rb 88.07% <0.00%> (-0.39%) ⬇️
lib/colorls/core.rb 89.95% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 442eca4...3a7552c. Read the comment docs.

@avdv
Copy link
Collaborator

avdv commented Mar 25, 2021

@dependabot merge

@dependabot-preview dependabot-preview bot merged commit 03d38fb into master Mar 25, 2021
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-tw-1.12.0 branch March 25, 2021 07:37
@dependabot-preview
Copy link
Contributor Author

This pull request will no longer be automatically closed when a new version is found as this pull request was created by Dependabot Preview and this repo is using a version: 2 config file. You can close this pull request and let Dependabot re-create it the next time it checks for updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants