Drop Ruby 2.5 #498
Merged
Drop Ruby 2.5 #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
=======================================
Coverage 89.18% 89.18%
=======================================
Files 8 8
Lines 555 555
=======================================
Hits 495 495
Misses 60 60
Continue to review full report at Codecov.
|
avdv
force-pushed
the
drop-ruby-2.5
branch
2 times, most recently
from
0b0240f
to
0e54101
Compare
Make the `test/run` script compatible to the ancient Bash version on macos. ``` test/run: line 56: conditional binary operator expected ``` Also, run `set -e` only for Bash >= 4. Otherwise the shell silently exits with a failure when a command (expectedly) fails. fix bogus test failure with Bash 3.2 on macos
It reached EOL with release 2.5.9, and no longer receives patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ruby 2.5 is no longer maintained. Users should upgrade.