Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offenses newly reported by rubocop-rspec #500

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

avdv
Copy link
Collaborator

@avdv avdv commented Feb 28, 2022

Description

The pessimistic version contraint on rubocop-rspec permitted minor version
updates of the dependency, which broke the tests again since version 2.9.0
introduced / changed offenses:

rbbe rake rubocop:auto_correct
Running RuboCop...
Inspecting 22 files
.................CC...

Offenses:

spec/color_ls/yaml_spec.rb:20:47: C: [Corrected] RSpec/BeEq: Prefer be over eq.
        expect(checker.sorted?(sort_type)).to eq true
                                              ^^
spec/color_ls_spec.rb:7:37: C: [Corrected] RSpec/BeNil: Prefer be_nil over be(nil).
    expect(ColorLS::VERSION).not_to be nil
                                    ^^^^^^

22 files inspected, 2 offenses detected, 2 offenses corrected

Allow only the patch version to increase automatically to avoid this in the future.

  • Relevant Issues : (none)
  • Relevant PRs : (none)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

The pessimistic version contraint on rubocop-rspec permitted minor version
updates of the dependency, which broke the tests again since version 2.9.0
introduced / changed offenses.

Allow only the patch version to increase automatically to avoid this in the future.
@avdv avdv merged commit 234815d into athityakumar:master Feb 28, 2022
@avdv avdv deleted the fix-rubocop-rspec branch February 28, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant