Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --inode (-i) flag #506

Merged
merged 6 commits into from
Mar 20, 2022
Merged

Add --inode (-i) flag #506

merged 6 commits into from
Mar 20, 2022

Conversation

goar5670
Copy link
Contributor

@goar5670 goar5670 commented Mar 19, 2022

Description

Thanks for contributing this Pull Request. Add a brief description of what this Pull Request does. Do tag the relevant issue(s) and PR(s) below. If required, add some screenshot(s) to support your changes.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022

Codecov Report

Merging #506 (cd394c0) into main (0b61d73) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   89.32%   89.43%   +0.11%     
==========================================
  Files           8        8              
  Lines         562      568       +6     
==========================================
+ Hits          502      508       +6     
  Misses         60       60              
Impacted Files Coverage Δ
lib/colorls/core.rb 90.28% <100.00%> (+0.20%) ⬆️
lib/colorls/flags.rb 88.31% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b61d73...cd394c0. Read the comment docs.

@goar5670 goar5670 changed the title Add inode Add --inode (-i) flag Mar 20, 2022
Copy link
Collaborator

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I only have a few suggestions.

lib/colorls/core.rb Outdated Show resolved Hide resolved
lib/colorls/core.rb Show resolved Hide resolved
Copy link
Collaborator

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@avdv avdv merged commit 092e25a into athityakumar:main Mar 20, 2022
@goar5670 goar5670 deleted the add-inode branch March 20, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants