Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --inode check #511

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Fix --inode check #511

merged 1 commit into from
Apr 4, 2022

Conversation

avdv
Copy link
Collaborator

@avdv avdv commented Apr 4, 2022

Description

The test failed on CI, since the inode number was a 6-digit number.

Failures:

  1) ColorLS::Flags with --inode flag shows inode number
     Failure/Error: expect { subject }.to output(/\d{7,}/).to_stdout

       expected block to output /\d{7,}/ to stdout, but output "      786913     Glück \n      786914     a-file \n      786915     a.md \n      786916     a.tx...  second-level/\n      786920     symlinks/\n      786924     z-file \n      786925     z.txt \n"
       Diff:
       @@ -1,8 +1,15 @@
       -/\d{7,}/
       +      786913     Glück 
       +      786914     a-file 
       +      786915     a.md 

The range of inodes is roughly 2 to 2^32 (depending on the filesystem).

  • Relevant Issues : (none)
  • Relevant PRs : (none)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

The range of inodes is roughly 2 to 2^32 (depending on the filesystem).

The test failed on CI, since the inode number was a 6-digit number.
@avdv avdv merged commit 729a6e0 into athityakumar:main Apr 4, 2022
@avdv avdv deleted the fix-test-failure branch April 4, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant