Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 1.22.0 to ~> 1.28.2 #520

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 25, 2022

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.28.2

Bug fixes

  • #10566: Fix a false positive for Lint/AmbiguousBlockAssociation when using proc is used as a last argument. (@​koic)
  • #10573: Fix a false positive for Layout/SpaceBeforeBrackets when there is a dot before brackets. (@​nobuyo)
  • #10563: Fix Style/BlockDelimiters unexpectedly deletes block on moving comment if methods with block are chained. (@​nobuyo)
  • #10574: Fix a false positive for Style/SingleArgumentDig when using dig with arguments forwarding. (@​ydah)
  • #10565: Fix a false positive and a true negative for Style/FetchEnvVar. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.28.2 (2022-04-25)

Bug fixes

  • #10566: Fix a false positive for Lint/AmbiguousBlockAssociation when using proc is used as a last argument. ([@​koic][])
  • #10573: Fix a false positive for Layout/SpaceBeforeBrackets when there is a dot before brackets. ([@​nobuyo][])
  • #10563: Fix Style/BlockDelimiters unexpectedly deletes block on moving comment if methods with block are chained. ([@​nobuyo][])
  • #10574: Fix a false positive for Style/SingleArgumentDig when using dig with arguments forwarding. ([@​ydah][])
  • #10565: Fix a false positive and a true negative for Style/FetchEnvVar. ([@​koic][])

1.28.1 (2022-04-21)

Bug fixes

  • #10559: Fix crash on CodeLengthCalculator if method call is not parenthesized. ([@​nobuyo][])
  • #10557: Fix a false positive for Style/FetchEnvVar when ENV['key'] is a receiver of ||=. ([@​koic][])

1.28.0 (2022-04-21)

New features

Bug fixes

  • #10528: Fix an infinite loop at autocorrect for Layout/CaseIndentation. ([@​ydah][])
  • #10537: Fix an incorrect auto-correct for Style/MultilineTernaryOperator when returning a multiline ternary operator expression with break, next, or method call. ([@​koic][])
  • #10529: Fix autocorrect for Style/SoleNestedConditional causes logical error when using a outer condition of method call by omitting parentheses for method arguments. ([@​nobuyo][])
  • #10530: Fix a false positive for Style/RedundantRegexpCharacterClass when using regexp character class with a character class containing multiple unicode code-points. ([@​koic][])
  • #10518: Fix a false positive for Style/DoubleNegation when inside returned conditional clauses with Ruby 2.7's pattern matching. ([@​koic][])
  • #10510: Fix an error for Style/SingleArgumentDig when using multiple dig in a method chain. ([@​koic][])
  • #10553: Fix crash with trailing tabs in heredocs for Layout/TrailingWhitespace. ([@​dvandersluis][])
  • #10488: Fix autocorrection for Layout/MultilineMethodCallIndentation breaks indentation for nesting of method calls. ([@​nobuyo][])
  • #10543: Fix incorrect code length calculation for few more patterns of hash folding asked. ([@​nobuyo][])
  • #10541: Fix an incorrect autocorrect for Style/SpecialGlobalVars when global variable as Perl name is used multiple times. ([@​koic][])
  • #10514: Fix an error for Lint/EmptyConditionalBody when missing second elsif body. ([@​koic][])
  • #10469: Fix code length calculation when kwargs written in single line. ([@​nobuyo][])

Changes

  • #10555: Deprecate IgnoredPatterns in favour of AllowedPatterns. ([@​dvandersluis][])
  • #10356: Add AllowConsecutiveConditionals option to Style/GuardClause and the option is false by default. ([@​ydah][])
  • #10524: Mark Style/RedundantInitialize as unsafe. ([@​koic][])

... (truncated)

Commits
  • 7222575 Cut 1.28.2
  • e9fc354 Update Changelog
  • 135bddb Merge pull request #10575 from nobuyo/fix-false-positive-for-layout-space-bef...
  • 490cb62 [Fix #10573] Fix a false positive for Layout/SpaceBeforeBrackets when there...
  • 7606e2c Merge pull request #10565 from ydah/fix_fetch_env_var
  • d8f3c8f Fix a false positive and a true negative for Style/FetchEnvVar
  • df09f42 Merge pull request #10576 from ydah/fix_single_argment_dig
  • dd8bf68 [Fix #10574] Fix a false positive for Style/SingleArgumentDig when using di...
  • a331f43 Merge pull request #10564 from nobuyo/fix-unexpected-block-deletion-when-styl...
  • f6e97b4 Merge pull request #10567 from koic/fix_a_false_positive_for_lint_ambiguous_b...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #520 (a131223) into main (c7f3ac8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   89.60%   89.60%           
=======================================
  Files           8        8           
  Lines         577      577           
=======================================
  Hits          517      517           
  Misses         60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f3ac8...a131223. Read the comment docs.

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.22.0...v1.28.2)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-tw-1.28.2 branch from bde25e5 to a131223 Compare April 26, 2022 20:10
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 6, 2022

Superseded by #525.

@dependabot dependabot bot closed this May 6, 2022
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-tw-1.28.2 branch May 6, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant