Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 1.22.0 to ~> 1.29.1 #526

Merged
merged 3 commits into from
May 13, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 12, 2022

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.29.1

Bug fixes

  • #10625: Restore the specification to TargetRubyVersion: 2.5. (@​koic)
  • #10569: Fix a false positive for Style/FetchEnvVar when using the same ENV var as if condition in the body. (@​koic)
  • #10614: Make Lint/NonDeterministicRequireOrder aware of require_relative. (@​koic)
  • #10607: Fix autocorrect for Style/RedundantCondition when there are parenthesized method calls in each branch. (@​nobuyo)
  • #10622: Fix a false positive for Style/RaiseArgs when error type class constructor with keyword arguments and message argument. (@​koic)
  • #10610: Fix an error for Naming/InclusiveLanguage string with invalid byte sequence in UTF-8. (@​ydah)
  • #10605: Fix autocorrect for Style/RedundantCondition if argument for method in else branch is hash without braces. (@​nobuyo)
Changelog

Sourced from rubocop's changelog.

1.29.1 (2022-05-12)

Bug fixes

  • #10625: Restore the specification to TargetRubyVersion: 2.5. ([@​koic][])
  • #10569: Fix a false positive for Style/FetchEnvVar when using the same ENV var as if condition in the body. ([@​koic][])
  • #10614: Make Lint/NonDeterministicRequireOrder aware of require_relative. ([@​koic][])
  • #10607: Fix autocorrect for Style/RedundantCondition when there are parenthesized method calls in each branch. ([@​nobuyo][])
  • #10622: Fix a false positive for Style/RaiseArgs when error type class constructor with keyword arguments and message argument. ([@​koic][])
  • #10610: Fix an error for Naming/InclusiveLanguage string with invalid byte sequence in UTF-8. ([@​ydah][])
  • #10605: Fix autocorrect for Style/RedundantCondition if argument for method in else branch is hash without braces. ([@​nobuyo][])

1.29.0 (2022-05-06)

New features

Bug fixes

  • #10586: Fix a false positive for Style/DoubleNegation when using define_method or define_singleton_method. ([@​ydah][])
  • #10579: Fix a false positive for Style/FetchEnvVar when calling a method with safe navigation`. ([@​koic][])
  • #10581: Fix a false positive for Style/FetchEnvVar when comparing with ENV['TERM']. ([@​koic][])
  • #10589: Fix autocorrect for Style/RaiseArgs with EnforcedStyle: compact and exception object is assigned to a local variable. ([@​nobuyo][])
  • #10325: Enhance Style/RedundantCondition by considering the case that variable assignments in each branch. ([@​nobuyo][])
  • #10592: Fix infinite loop on Style/MultilineTernaryOperator if using assignment method and condition/branch is multiline. ([@​nobuyo][])
  • #10536: Fix validation for command-line options combination of --display-only-fail-level-offenses and --auto-correct. ([@​nobuyo][])

Changes

  • #10577: (Compatibility) Drop support for Ruby 2.5 and JRuby 9.2 (CRuby 2.5 compatible). ([@​koic][])
  • #10585: Enhance the autocorrect for Style/FetchEnvVar. ([@​johnny-miyake][])
  • #10577: (Breaking) Retire Lint/UselessElseWithoutRescue cop. ([@​koic][])

1.28.2 (2022-04-25)

Bug fixes

  • #10566: Fix a false positive for Lint/AmbiguousBlockAssociation when using proc is used as a last argument. ([@​koic][])
  • #10573: Fix a false positive for Layout/SpaceBeforeBrackets when there is a dot before brackets. ([@​nobuyo][])
  • #10563: Fix Style/BlockDelimiters unexpectedly deletes block on moving comment if methods with block are chained. ([@​nobuyo][])
  • #10574: Fix a false positive for Style/SingleArgumentDig when using dig with arguments forwarding. ([@​ydah][])
  • #10565: Fix a false positive and a true negative for Style/FetchEnvVar. ([@​koic][])

1.28.1 (2022-04-21)

Bug fixes

... (truncated)

Commits
  • efd33a0 Cut 1.29.1
  • 0050625 Update Changelog
  • b0eb6d7 [Fix #10622] Fix a false positive for Style/RaiseArgs
  • b54b9cf [Fix #10625] Restore the specification to TargetRubyVersion: 2.5
  • fbe6b7b Merge pull request #10615 from koic/make_lint_non_deterministic_require_order...
  • 961f498 [Fix #10614] Make Lint/NonDeterministicRequireOrder aware of `require_relat...
  • cfdd105 Unify to remove 'This cop' from cop description in default.yml
  • 60d0c1d Merge pull request #10611 from ydah/tweak-word
  • 7ebfcf5 Tweak uniformity of expression was implemented
  • 5912850 Merge pull request #10609 from nobuyo/fix-autocorrect-for-style-redundant-con...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.22.0...v1.29.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2022

Codecov Report

Merging #526 (3ffea29) into main (0123267) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #526   +/-   ##
=======================================
  Coverage   90.81%   90.81%           
=======================================
  Files           8        8           
  Lines         577      577           
=======================================
  Hits          524      524           
  Misses         53       53           
Impacted Files Coverage Δ
lib/colorls/flags.rb 88.88% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0123267...3ffea29. Read the comment docs.

avdv added 2 commits May 13, 2022 19:18
Replace with `Struct`, or use `instance_double` in tests.
@avdv avdv merged commit b99e937 into main May 13, 2022
@avdv avdv deleted the dependabot/bundler/rubocop-tw-1.29.1 branch May 13, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants