Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(483): adds support for --without-icons feature flag #552

Merged
merged 4 commits into from
Oct 27, 2022

Conversation

karandeepmadaan
Copy link
Contributor

Description

  • Relevant Issues : Add CLI option to disable icon view #483
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

image

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Base: 90.81% // Head: 90.86% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (5e70184) compared to base (6eb4b6d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
+ Coverage   90.81%   90.86%   +0.04%     
==========================================
  Files           8        8              
  Lines         577      580       +3     
==========================================
+ Hits          524      527       +3     
  Misses         53       53              
Impacted Files Coverage Δ
lib/colorls/core.rb 90.80% <100.00%> (+0.07%) ⬆️
lib/colorls/flags.rb 88.95% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@athityakumar athityakumar changed the title Feature/without icons feat(483): adds support for --without-icons feature flag Oct 27, 2022
@athityakumar athityakumar merged commit a0a78da into athityakumar:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants