-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When the argument is a file with path provided, show the relative path of the file #594
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
+ Coverage 92.04% 92.13% +0.08%
==========================================
Files 8 8
Lines 616 623 +7
==========================================
+ Hits 567 574 +7
Misses 49 49
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but no need to bump the version.
lib/colorls/version.rb
Outdated
@@ -1,5 +1,5 @@ | |||
# frozen_string_literal: true | |||
|
|||
module ColorLS | |||
VERSION = '1.5.0' | |||
VERSION = '1.5.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't release version 1.5.0 yet, so no need to bump the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avdv Do you need help in fixing the release script? By not releasing these latest changes, we are robbing people of all the new features being created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, but I already created a PR which fixes the problem. But I cannot merge it without an approval from another maintainer.
@@ -11,6 +11,40 @@ | |||
raise "colorls exited with #{e.status}" unless e.success? | |||
end | |||
|
|||
let(:a_txt_file_info) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
This reverts commit 414820b.
Thank you! |
Description
In order to demonstrate what this PR does, I am displaying the difference in the output of the command
colorls exe/colorls
(which is a file) before and after this PRBefore this PR
After this PR
Comment
This PR takes this gem one step closer to the behaviour of the in-built
ls
command.Details