Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ronn-ng instead of ronn #625

Closed
wants to merge 1 commit into from
Closed

Use ronn-ng instead of ronn #625

wants to merge 1 commit into from

Conversation

avdv
Copy link
Collaborator

@avdv avdv commented Sep 2, 2024

Description

ronn is dead, it depends on hpricot which is also dead.

Hopefully, this will make CI pass again.

  • Relevant Issues : (none)
  • Relevant PRs : (none)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

ronn is dead, it depends on hpricot which is also dead.
@avdv
Copy link
Collaborator Author

avdv commented Sep 2, 2024

Hopefully, this will make CI pass again.

🥳 this worked. @athityakumar could you please approve this PR? I cannot approve / merge my own PRs here.

@avdv avdv requested a review from athityakumar September 2, 2024 17:49
@avdv
Copy link
Collaborator Author

avdv commented Sep 9, 2024

Included in #622

@avdv avdv closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant