Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misuse of with-open #36

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Fix misuse of with-open #36

merged 2 commits into from
Jun 15, 2023

Conversation

athos
Copy link
Owner

@athos athos commented Jun 12, 2023

The root cause of #35 seems to be the fact that even after adding the IReader protocol's own close method in 8519c72 instead of Closeable#close, some code has been using with-open to close the IReader implementation as before by mistake.

This PR fixes those misuses of with-open.

@athos athos added the bug Something isn't working label Jun 12, 2023
@athos athos force-pushed the fix/bad-call-to-with-open branch from bbecdd0 to 094c782 Compare June 15, 2023 15:29
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 90.90% and project coverage change: +0.04 🎉

Comparison is base (ef49810) 88.96% compared to head (094c782) 89.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   88.96%   89.00%   +0.04%     
==========================================
  Files          13       13              
  Lines        1015     1019       +4     
  Branches       48       48              
==========================================
+ Hits          903      907       +4     
  Misses         64       64              
  Partials       48       48              
Impacted Files Coverage Δ
src/pogonos/api.clj 84.81% <0.00%> (ø)
src/pogonos/core.cljc 85.57% <100.00%> (ø)
src/pogonos/reader.cljc 94.77% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@athos athos marked this pull request as ready for review June 15, 2023 15:37
@athos athos merged commit 1445119 into master Jun 15, 2023
@athos athos deleted the fix/bad-call-to-with-open branch June 15, 2023 15:40
@athos athos mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant