Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix -j behavior #308

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix -j behavior #308

merged 1 commit into from
Jan 23, 2024

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Jan 22, 2024

This was broken after my PR - -j2 would lead to 2 additional worker threads, yielding 3 threads in total.

And it would default to single-thread mode on a dual-core machine.

@kinke
Fix -j behavior
7979360 
This was broken after my PR - `-j2` would lead to 2 additional worker
threads, yielding 3 threads in total.

And it would default to single-thread mode on a dual-core machine.
@kinke
Copy link
Contributor Author

kinke commented Jan 22, 2024

This was broken in ed48a4f. And that commit also changed the behavior for numThreads == 0 - from 'use all logical cores' to single-threaded mode (as TaskPool(0) constructs an empty TaskPool without workers). I've kept that breaking change here.

@atilaneves atilaneves merged commit b362027 into atilaneves:master Jan 23, 2024
13 of 15 checks passed
@kinke kinke deleted the fix_j branch January 23, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinke @atilaneves