Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric update #205

Merged
Merged

Conversation

DanteNiewenhuis
Copy link
Contributor

Summary

Changed the type of multiple metrics.

Implementation Notes ⚒️

  • All metrics that measure time, such as cpu_time_active or uptime are now in milliseconds.
  • All timestamps are converted to milliseconds as well.

External Dependencies 🍀

N/A

Breaking API Changes ⚠️

  1. Experiments might expect datetime object when loading into something like pandas. This will not work with the new int type, but should be easy to update
  2. Some metrics will result in values 1000 * higher because they are converted from seconds to milliseconds.

Simply specify none (N/A) if not applicable.

@DanteNiewenhuis DanteNiewenhuis merged commit d28002a into atlarge-research:master Feb 16, 2024
5 checks passed
@DanteNiewenhuis DanteNiewenhuis deleted the metric-update branch February 16, 2024 14:11
DanteNiewenhuis added a commit to DanteNiewenhuis/opendc that referenced this pull request Feb 18, 2024
* Updated metrics to consistently be ms

* Updated metrics to consistently be ms

* Updated metric documentation on the site

* Updated some tests to work with the updated metrics
@DanteNiewenhuis DanteNiewenhuis linked an issue Apr 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update metrics
2 participants