Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Topology format #208

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

DanteNiewenhuis
Copy link
Contributor

@DanteNiewenhuis DanteNiewenhuis commented Mar 5, 2024

Summary

Updated the format of Topology files to JSON.

Implementation Notes ⚒️

All Topology files should now be provided in JSON format

External Dependencies 🍀

N/A

Breaking API Changes ⚠️

N/A

Simply specify none (N/A) if not applicable.](fixme: Fix failures and enable)

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 66.05505% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 71.08%. Comparing base (5864cbc) to head (ff39550).

Files Patch % Lines
...lin/org/opendc/compute/topology/specs/JSONSpecs.kt 56.81% 14 Missing and 5 partials ⚠️
...c/simulator/compute/power/CPUPowerModelsFactory.kt 14.28% 5 Missing and 1 partial ⚠️
...tlin/org/opendc/compute/topology/TopologyReader.kt 50.00% 3 Missing ⚠️
...n/org/opendc/compute/topology/TopologyFactories.kt 92.00% 2 Missing ⚠️
...endc/experiments/greenifier/GreenifierPortfolio.kt 0.00% 2 Missing ⚠️
...ndc/compute/service/scheduler/ComputeSchedulers.kt 0.00% 1 Missing ⚠️
...te/service/scheduler/filters/VCpuCapacityFilter.kt 0.00% 1 Missing ⚠️
...e/service/scheduler/weights/VCpuCapacityWeigher.kt 0.00% 1 Missing ⚠️
...ain/kotlin/org/opendc/compute/simulator/SimHost.kt 90.90% 0 Missing and 1 partial ⚠️
.../opendc/experiments/greenifier/GreenifierRunner.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #208      +/-   ##
============================================
- Coverage     71.33%   71.08%   -0.26%     
+ Complexity     2199     2191       -8     
============================================
  Files           354      355       +1     
  Lines          9958     9966       +8     
  Branches       1045     1052       +7     
============================================
- Hits           7104     7084      -20     
- Misses         2532     2556      +24     
- Partials        322      326       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanteNiewenhuis DanteNiewenhuis merged commit 960b3d8 into atlarge-research:master Mar 5, 2024
6 checks passed
@DanteNiewenhuis DanteNiewenhuis deleted the cpu_fix branch March 5, 2024 15:50
@DanteNiewenhuis DanteNiewenhuis changed the title Cpu fix Updated Topology format Mar 21, 2024
@DanteNiewenhuis DanteNiewenhuis linked an issue Mar 21, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update topology format
2 participants