Updated the power models and added tests #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanteNiewenhuis
force-pushed
the
power_model_fix
branch
from
9360cb4
to
1e71860
Compare
sacheendra
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation Notes ⚒️
The square root model could return NaN values.
This was caused by negative utilization values being passed to the model.
The utilization was negative due to floating point errors, creating a very small negative number.
The utilization value is now always clamped in (0.0, 1.0).
External Dependencies 🍀
N / A
Breaking API Changes⚠️
The changes to the power models can result in very small value differences.
Simply specify none (N/A) if not applicable.