Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CPU limit problem #234

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

DanteNiewenhuis
Copy link
Contributor

  • Fixed a problem which caused the CPU limit to be much lower than it should be.
  • AllocationPolicy is now properly exposed to the user

Summary

A small summary of the requirements (in one/two sentences).

Implementation Notes ⚒️

N / A

External Dependencies 🍀

N / A

Breaking API Changes ⚠️

N / A

Simply specify none (N/A) if not applicable.

…hould be.

AllocationPolicy is now properly exposed to the user
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (23caa62) to head (71d7b38).

Files Patch % Lines
...g/opendc/experiments/base/runner/ScenarioRunner.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #234   +/-   ##
=========================================
  Coverage     63.85%   63.85%           
  Complexity     2135     2135           
=========================================
  Files           380      380           
  Lines         10885    10885           
  Branches       1146     1146           
=========================================
  Hits           6951     6951           
  Misses         3601     3601           
  Partials        333      333           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanteNiewenhuis DanteNiewenhuis merged commit b6153bb into atlarge-research:master Jun 17, 2024
6 checks passed
@DanteNiewenhuis DanteNiewenhuis deleted the cpuLimit-fix branch June 17, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants