Bitbucket: update merge_pull_request method to add merge_message, close_source_branch and merge_strategy parameters #1437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I recently discovered this library, nice work btw, and wanted to use it to automate some CICD in my company.
When trying to merge pull requests I noticed that merge_pull_request method was failing, after some investigation and searching in Bitbucket API docs I found that some parameters were missing from the POST body --> source
This PR aims to add these parameters. I took the liberty of also adding type hints and validation via Enum class for the MergeStrategies, hope this is okay with you.
I ran
make qa
and here is the final output:I did not add any test though since the CONTRIBUTOR.rst doesn't mention anything about it, but if you want me to, please let me know.
Thanks!