This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
Remove support for using JSX without React #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad-docs/brisk-docs into dpisani/AFP-234-standard-babel-config
pyupew
previously approved these changes
Mar 26, 2019
Noviny
suggested changes
Mar 26, 2019
.eslintrc
Outdated
| "emotion/jsx-import": "error", | ||
| "react/jsx-filename-extension": "off", | ||
| "react/require-default-props": "off", | ||
| "jsx-a11y/anchor-is-valid": "off", |
There was a problem hiding this comment.
Can we pass options as suggested here:
https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/402
instead of turning this rule off?
There was a problem hiding this comment.
Tracked as AFP-238
| @@ -24,6 +22,7 @@ const AllPackagesNavContent = ({ data }) => ( | |||
| <HeaderSection> | |||
| {({ css }) => ( | |||
| <div | |||
| // eslint-disable-next-line emotion/jsx-import | |||
There was a problem hiding this comment.
Can we add a description of this and what this is?
Noviny
approved these changes
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one step to having a consistent babel configuration across the repo