Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Adding OTLP Configuration #655

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

MovieStoreGuy
Copy link
Contributor

Context

This is the expected configuration of the OTLP backend once releases.

Changes

  • Added OTLP backend configuration

@MovieStoreGuy MovieStoreGuy self-assigned this Jan 10, 2024
Copy link
Contributor

@Excaleo Excaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question on whether we should typedef, but not a blocker

Transport: "default",
MaxRequests: runtime.NumCPU() * 2,
TimerConversion: "AsGauge",
HistogramConversion: "AsGauge",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we type def AsGauge and AsHistograms since they're fixed constants?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will change into single value within the next PR, so I am not too worried

@MovieStoreGuy MovieStoreGuy merged commit d841d68 into master Jan 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants