-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend OTLP: Adding OTLP as a configurable backend for GoStatsD #656
Conversation
008923b
to
69a647a
Compare
69a647a
to
3a97091
Compare
I've parked the additional actions, I would like to follow up on those to be done within the transport instead of within the encoding step. |
3a97091
to
7d31e1d
Compare
func newDefaultConfig() *Config { | ||
return &Config{ | ||
Transport: "default", | ||
MaxRequests: runtime.NumCPU() * 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this too conservative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it really depends on the backend supporting out of order writes, if it does, you can open this up wide, otherwise, restricting it is a good idea.
…atsd into limit-concurrent-req-n-batch
Limit the amount of concurrent request to `maxRequests`
Context
This adds in support for OTLP as a supported backend for Gostatsd however it does come with some limitations:
Events will need to be exported as logs which currently isn't written yet and ignored for this PR.
Migration
To ensure the highest amount of compatibility with other configurable backends, timers can either exported as Gauges with the calculated value added as suffix to the metric. This should ensure that existing metrics being emitted to your configured backend should maintain the same semantic value when visualising / evaluating within metrics platform.
Outstanding