Disable keep-alive connections.

[rogerhu]

If there are a sufficient # of connections opened/file descriptors exceeded, Camo will start returning back 404 because of the saturated number of connections.

[atmos]

Can you write a test that explains what you're going for more clearly?

[rogerhu]

Bottom line: NodeJS sends Connection: keep-alive headers when you make outbound requests. If you have Camo making 1000+ simulataneous requests, you will be capped by the total # of file descriptors per process and will depend on the socket timeout of the connection to be reclaimed.

http://nodejs.org/api/http.html

I looked through the Ruby test suite and tried to run it just now, though there seems to be some incompat issues with Ruby v2.1 -- but essentially this is what I would want:

def test_closes_connections
  uri = request_uri("http://example.org/")
  response = RestClient.get("#{config['host']}#{path}")
  assert_equal "Connection", "close"
end

[rogerhu]

I looked through your tests and they appear to be integration tests. They don't verify what headers are being issued by NodeJS in https://github.com/atmos/camo/blob/master/server.js#L115. The agent: parameter is left to be default, which is causing keep-alive connections to occur for each proxy request.

[rogerhu]

I was able to verify by using a netcat listener on a proxied site that Camo accesses and could see Connection: close instead of Connection: keep-alive.

[rvarshney]

👍

[iritmalka]

👍

[adepue]

Yes please. I use a cronjob to cycle the process now to get back sockets.

[akshayjshah]

👍

[rogerhu]

Thanks! Wondering when the next release will be out.. :)

[atmos]

There aren't any real releases. I can tag a newer version if that'll help you.

[rogerhu]

Would appreciate it...thanks!

[atmos]

I tagged v2.2.0