Refactor scattering za grid #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olemke
force-pushed
the
refactor-scattering-zagrid
branch
from
dbc3dee to
e05dbec
Compare
olemke
force-pushed
the
refactor-scattering-zagrid
branch
from
afe39d3 to
ed0b569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make scattering za grid accessible in Python interface.
Remove exposure of
ZenithAngleGridand refactored the variant alternatives.ZenithAngleGrids support the numpy interface now.
@simonpf We also removed the inheritance from Vector as the interface was not used anywhere anyway and it simplifies the nanobind interface. Each grid contains a member
anglesinstead now.