Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

textDocument/rename #13

Closed
damieng opened this issue Mar 31, 2017 · 6 comments
Closed

textDocument/rename #13

damieng opened this issue Mar 31, 2017 · 6 comments

Comments

@damieng
Copy link
Contributor

damieng commented Mar 31, 2017

The textDocument/rename protocol lets you rename a symbol and automatically update all associated symbols.

We could implement this with a command and a right-menu button but it would also need a ui for the new symbol unless we could do it inline.

@hansonw
Copy link
Contributor

hansonw commented Mar 31, 2017

We've got a UI for that in Nuclide as well. It's a tad heavyweight (since it's designed to support more complex refactorings) so I'm not sure if you'd want to start from there or start afresh.

https://github.com/facebook/nuclide/blob/master/pkg/nuclide-refactorizer

The basic flow is right click a symbol, click Refactor in the context menu, select rename, and then type in a new name. There's also an explicit command for quickly just renaming.

@lierdakil
Copy link
Contributor

What's the status on this? Minimal implementation should be doable in less than 100 lines... For instance, https://github.com/atom-haskell/hie-lsp-adapter/blob/master/lib/main.js#L20

@damieng
Copy link
Contributor Author

damieng commented Apr 12, 2018

Feel free to send a PR.

@lierdakil
Copy link
Contributor

Sure, I'll see what I can do. Just was checking if anyone's working on it already.

@arxanas
Copy link

arxanas commented Aug 13, 2018

See also facebookarchive/atom-ide-ui#145 (comment)

@BenjaminNavarro
Copy link

I'm not very familiar with Atom extensions development but I'd like to contribute to this issue. Any tips on where to start?

lexi-lambda added a commit to lexi-lambda/atom-languageclient that referenced this issue Jul 2, 2019
@Aerijo Aerijo closed this as completed in 693b338 Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants