This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Added option to always skip over pair in front of cursor #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winstliu
reviewed
Dec 4, 2017
lib/bracket-matcher.coffee
Outdated
| @@ -54,11 +54,11 @@ class BracketMatcher | |||
|
|
|||
| skipOverExistingClosingBracket = false | |||
| if @isClosingBracket(text) and nextCharacter is text and not hasEscapeCharacterBeforeCursor | |||
| if bracketMarker = _.find(@bracketMarkers, (marker) -> marker.isValid() and marker.getBufferRange().end.isEqual(cursorBufferPosition)) | |||
| if (bracketMarker = _.find(@bracketMarkers, (marker) -> marker.isValid() and marker.getBufferRange().end.isEqual(cursorBufferPosition))) or @getScopedSetting("bracket-matcher.alwaysSkipClosingPairs") | |||
There was a problem hiding this comment.
This conditional is getting a bit long - mind splitting it up into two lines?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This pull requests adds a new option (
bracket-matcher.alwaysSkipClosingPairs) that, when enabled, will always move the cursor to the right when the cursor is behind a closing pair.Example:
After pressing
(, the editor will be(|).After pressing
), the editor will be()|.After moving the cursor left, the editor will be
(|)again.After pressing
)with this option set tofalse, the editor will be()|)But if the option was
true, the editor would be()|Alternate Designs
None
Benefits
This behavior is similar to the auto-pairs and delimitMate Vim plugins. After switching to Atom from Vim with one of those plugins, this behavior will be much more familiar.
Possible Drawbacks
None, this option is disabled by default.
Applicable Issues
None