"Select Next" no longer works with multiline selections

[dead-claudia]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

"Select Next" no longer works with multiline selections

Steps to Reproduce

1. Enter the following text:

aa
aa

aa
aa

2. Select the first two aa's
3. Trigger find-and-replace:select-next (via command panel, Ctrl+D, etc.)

Expected behavior: The second set of aa's to be selected.

Actual behavior: Nothing.

Reproduces how often: 100%

Versions

You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

Atom: v1.14.0

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

Last version I remember working was 1.12.7, but I just updated yesterday.

[dead-claudia]

This is a productivity killer for me, because I used that extensively. It makes refactoring far easier.

[winstliu]

Confirmed on Atom 1.15.0-dev-ae6a7a0.

[dead-claudia]

The break happened between 1.13.1 and 1.14.0-beta0, from some manual bisecting I did in spare time using fresh versions. Problem is, I can't repro it at all in Atom 1.13.1, even after upgrading its package (find-and-replace@0.204.5) to the version in Atom 1.14.0-beta.0 (find-and-replace@0.205.1). So it has to be an issue with another package, likely Atom Core itself.

…

----- Isiah Meadows me@isiahmeadows.com

On Thu, Feb 9, 2017 at 9:25 AM, Wliu ***@***.***> wrote: Confirmed on Atom 1.15.0-dev-ae6a7a0. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#854 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AERrBNN6Dq1AeSue2CwzUMQV_NEI1nIYks5rayHkgaJpZM4L7zGQ> .

[dead-claudia]

If it happens to be in core (neither text-buffer nor event-kit had any changes to likely cause problems), it's probably no earlier than this commit, and in this file: atom/atom@5ee3dbe Just an educated guess.

…

----- Isiah Meadows me@isiahmeadows.com

On Thu, Feb 9, 2017 at 12:20 PM, Isiah Meadows ***@***.***> wrote: The break happened between 1.13.1 and 1.14.0-beta0, from some manual bisecting I did in spare time using fresh versions. Problem is, I can't repro it at all in Atom 1.13.1, even after upgrading its package ***@***.***) to the version in Atom 1.14.0-beta.0 ***@***.***). So it has to be an issue with another package, likely Atom Core itself. ----- Isiah Meadows ***@***.*** On Thu, Feb 9, 2017 at 9:25 AM, Wliu ***@***.***> wrote: > Confirmed on Atom 1.15.0-dev-ae6a7a0. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#854 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AERrBNN6Dq1AeSue2CwzUMQV_NEI1nIYks5rayHkgaJpZM4L7zGQ> > . >

[maxbrunsfeld]

Sorry about this, folks. The fix will go out today in v1.14.1 and v1.15.0-beta1.

[nathansobo]

This is fixed in 1.14.1, which I just published.

[kidbrax]

So should we just be able to copy and paste multiline segments into the find dialog? Or do we need to explicitly add in the newline codes? It doesn't seem to work either way for me. Anyway you could provide a simple sample?

[winstliu]

This issue was referring to the find-and-replace:select-next command, ctrl/cmd-d by default. Basically like an inline find-and-replace.