-
Notifications
You must be signed in to change notification settings - Fork 57
Updated oniguruma dependency to support node.js 6 #74
Conversation
@@ -6,6 +6,8 @@ notifications: | |||
on_failure: change | |||
|
|||
node_js: | |||
- 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we always test the latest Node version, eg using node
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would just list the versions explicitly. Most projects do it like that.
@50Wliu I see you added the |
Just some basic regression testing should suffice, though you probably know more about what needs to be done than I do :). |
oniguruma doesn't seem to have a changelog or release notes. Hey @zcbenz, @alexandrudima, and @evanlucas: do you know what breaking change happened in oniguruma from 5 to 6? |
And the relevant comment:
To benefit from caching between calls on the same scanner instance you need to create a OnigString up-front. I explain the reason behind that in the PR. |
hey ya'll- what can i do to help move this forward? |
Just landed this in a new major version: 6.0.0 |
zomg amazing!! thank you so much! 🎉 |
Fixes #72