Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Update Debian/Ubuntu section of installing-atom.d #711

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ThamesDev
Copy link

Description of the Change

In your detailed Debian/Ubuntu installation guide, the command apt-key is used. This command is being deprecated. Instead, I'd like to suggest this more future-proof option, using gpg --dearmor | sudo tee /usr/share/keyrings/atom-archive-keyring.gpg. Please tell me if there are any modifications you'd like me to make.

Release Notes

N/A

apt-key has been deprecated. Here I have suggested an alternative, (slightly more future-proof) way to install. Apologies if the code isn't the most efficient, I'm very new to this!
Clean up the code, remove an unnecessary comment.
Update installing-atom.md
@hwittenborn
Copy link
Contributor

hwittenborn commented Jul 6, 2021

In their defense packagecloud themselves are recommending the apt-key approach.

Regardless, I completely agree. Exporting to a keyfile is way more secure, as the GPG key would then only be able to verify packages for the Atom repository, and not things like the Debian and Ubuntu repositories.

Copy link
Contributor

@hwittenborn hwittenborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

@hwittenborn
Copy link
Contributor

hwittenborn commented Jul 22, 2021

This last thing isn't required or anything, but just a general improvement:

This line:

 $ sudo sh -c 'echo "deb [signed-by=/usr/share/keyrings/atom-archive-keyring.gpg arch=amd64] https://packagecloud.io/AtomEditor/atom/any/ any main" > /etc/apt/sources.list.d/atom.list'

could be:

 $ echo "deb [signed-by=/usr/share/keyrings/atom-archive-keyring.gpg arch=amd64] https://packagecloud.io/AtomEditor/atom/any/ any main" | sudo tee /etc/apt/sources.list.d/atom.list'

You're thus only running the sudo command when writing out to the file (that part isn't really a big deal though), and it's just a bit cleaner imo.

@ThamesDev
Copy link
Author

Sorry I didn't reply to this earlier, that's a good idea, I'll do it when I next have access to my laptop.

@hwittenborn
Copy link
Contributor

All good! Sounds great then too.

@hwittenborn
Copy link
Contributor

hwittenborn commented Jul 28, 2021

Actually, on second though now, it would probably be a better idea to make that a separate PR. If the people on the Atom team end up not wanting to change the command, it's just going to be tedious to have to change everything again.

@ThamesDev
Copy link
Author

Ok, so it's ready then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants